Fix spacing issue with HTML4 images #1199
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bug was introduced in #1185, it looks like the HTML4 selector changed to not include directly descendents of `.section` elements.
Collaborator
Author
Blendify
approved these changes
Aug 12, 2021
Member
Blendify
left a comment
Blendify
left a comment
There was a problem hiding this comment.
I am unsure exactly also, we really need to better organize and comment what styling goes to what markup
Collaborator
Author
|
Heh yeah, seems we might have some investigation to do |
mathewgomas
pushed a commit
to mathewgomas-alfred/mathewgomas.io
that referenced
this pull request
Dec 8, 2024
Partially backported the changes from: - readthedocs/sphinx_rtd_theme#1185 - readthedocs/sphinx_rtd_theme#1199 BUG: 440203
kdesysadmin
pushed a commit
to KDE/documentation-docs-krita-org
that referenced
this pull request
May 13, 2025
Partially backported the changes from: - readthedocs/sphinx_rtd_theme#1185 - readthedocs/sphinx_rtd_theme#1199 BUG: 440203 (cherry picked from commit c2e98c6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug was introduced in #1185, it looks like the HTML4 selector
changed to not include directly descendents of
.sectionelements.I believe the issue was the missing
>introduced here:https://github.com/readthedocs/sphinx_rtd_theme/pull/1185/files#diff-2ad748ac9ebc515229907afab210e3bb370986d3db3a377f052ee5048dcc5b6cR36
But I'm also not familiar with the element that these rules are trying to target.
Fixes #1198